-
Notifications
You must be signed in to change notification settings - Fork 2
Update wraps #223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Update wraps #223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code Coverage Summary
Results for commit: 5d7a072 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
…luded, but it isn't now
…cluded, but it isn't now
gcc 15 in mingw64 changed some things, and now we need more define cheks, to correctly link the library with MSYS2
msvc doesn't care, if I say dllimport ona definition, but MSYS2 requires the definition and declaration to be seperated, when I use dllimports / exports this mainyl is the case for = delete functions and some missed implementations, that were still in .hpp files
- unify the complex and complicated #ifdef chains for windows, MSYS2, gcc etc. - also rename the files to export_symbols so that it is not called windows.hpp
…equired for the core library
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.